"Aaron Schulz" posted a comment on MediaWiki.r104688. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104688#c27202
Commit summary for MediaWiki.r104688: Followup r104274, r104676. Fix the bug that broke fr. Forgot to rawurldecode path contents. Also add /u just for sanity sake. Add new tests for url encoding, unicode, and length edge cases. Aaron Schulz's comment: Is WebRequest::getPathInfo() expected to at least set the 'title' key? What if we have a path rule with either a) not 'title' and no $1 or b) 'title' set to false? If that rule is matched, then the result will not have 'title' in the array. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
