"Tim Starling" posted a comment on MediaWiki.r105161.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105161#c27240

Commit summary for MediaWiki.r105161:

Skip replaceInternalLinks2 for js/css pages

Just skip the whole replaceInternalLinks2 parser function whenever we hit
js/css pages. Previous patch r103476 only handled Category links which was
not enough.

Tim Starling's comment:

As far as I can tell, it's not affecting page views. There was a 
[https://bugzilla.wikimedia.org/show_bug.cgi?id=32450#c5 report] about the 
categories showing up at the bottom of the page, but that might have just been 
speculation. I couldn't reproduce it and the original bug reporters didn't 
mention it. It's hard to see how it could happen, since on page view, the page 
is not parsed and the parser cache is not tried. I'm pretty sure this is purely 
an issue with WikiPage::prepareTextForEdit() and WikiPage::doEditUpdates(), 
neither of which check for CSS/JS pages.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to