"Khorn (WMF)" posted a comment on MediaWiki.r106109. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106109#c27682
Commit summary for MediaWiki.r106109: Data handling cleanup in DonationInterface, part 2 of [some]. ALL FORM CLASSES: Removed the $form_data array. All data will now be fetched directly from the gateway adapter object via Gateway_Form::getEscapedValue(). Started work removing what will hopefully work out to be all instances of child form classes touching $wgRequest or $wgOut directly: These will either be functionalized and moved to Gateway_Form, added to the data population and normalization routines in DonationData, or removed entirely. Khorn (WMF)'s comment: Bah, I knew there was going to be a find-and-replace error in the sea of finds and replaces I had to do for all this! ...on the other hand, what the heck is a form doing assigning values to form_data? Ah! I just noticed, this is TwoStepAmount. That form is not a form we will ever have in production, as it was one dev's personal sandbox and should probably be removed or blacklisted or something. Thanks, man. I'll fix it. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
