"Nikerabbit" posted a comment on MediaWiki.r106404.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106404#c27821

Commit summary for MediaWiki.r106404:

unfinished code, will follow up soonish, from other device

Nikerabbit's comment:

<pre>
+               parent::__construct( 'EditInstitution', 'epadmin', false );
</pre>

Can you use a setter instead of boolean parameter in the constructor? It's not 
readable.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to