"Catrope" changed the status of MediaWiki.r103276 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103276#c27917
Old Status: new > New Status: ok Commit summary for MediaWiki.r103276: [RL2] Implement "new category" ajax *Implement "new category" ajax -- Adds dynamic option at the bottom of the category dropdowb -- When chosen shows the text input and focusses it -- Onchange/onblur* of the input, update the gadget blob -- When drop down isn't on the "new category" update category to chosen option in gadget blob * Other minor changes -- comment fixes, optimalization, clean up * Note: .hide() is called on the input, no problem with flashing here since all this is build off-DOM before the dialog even appears. * TODO: Verify this works properly in older versions of IE. Catrope's comment: <pre> + .prop( 'placeholder', mw.msg( 'gadgetmanager-prop-category-new' ) ) </pre> If you intend for this to work in browsers that don't support the placeholder attribute (I see Firefox supports it nowadays, I didn't know that), you need to use jquery.placeholder's emulation. Call .placeholder() after setting the property, and add a dependency on jquery.placeholder . That said, the placeholder isn't very important, so we can probably afford not to do the emulation. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
