"Catrope" changed the status of MediaWiki.r107442 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107442#c28615
Old Status: new > New Status: fixme Commit summary for MediaWiki.r107442: move item data from inside the class name to data attributes, standardized selector name, now checking for type with id while loading mah items Catrope's comment: This commit itself is good, but it's missing changes to the HTML output by the PHP side of the extension to conform to what the new JS expects (markashelpful-item class, data-markashelpful-item and data-markashelpful-type attributes). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
