"Aaron Schulz" changed the status of MediaWiki.r107376 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107376#c28852
Old Status: new > New Status: fixme Commit summary for MediaWiki.r107376: Added support for stored procedures/functions to MySQL: * Refactored DatabaseBase::sourceStream(), made it possible for descendant classes to alter its behaviour w/o having to redo it completely like Oracle does. * MySQL class now supports specifying DELIMITER. * Thrown away the mess of catering for double semicolon. If it's a problem, fix your .sql files! * Haven't actually touched Oracle. * Tests! Aaron Schulz's comment: <pre> 1) DatabaseTest::testStoredFunctions DBQueryError: A database error has occurred. Did you forget to run maintenance/update.php after upg rading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script Query: CREATE FUNCTION mw_test_function() RETURNS int DETERMINISTIC BEGIN SET @foo = 21; RETURN @foo * 2; END Function: DatabaseBase::sourceFile( D:\www\MW_trunk\phase3/tests/phpunit/data/db/mysql/functions.sql ) Error: 1419 You do not have the SUPER privilege and binary logging is enabled (you *might* want to u se the less safe log_bin_trust_function_creators variable) (localhost) </pre> _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
