On Wed, Jan 4, 2012 at 12:10 AM, IAlex <ialex.w...@gmail.com> wrote:

> I added those fields to the Title class to avoid some DB queries and avoid
> code
> duplication.


*nod* they're just not generally applicable to many circumstances, and
really are page-data not title-data to begin with.


> The problem is that currently the WikiPage instance created in
> Wiki.php is not stored in the context object (you can grep for
> "WikiPage::factory"
> to see how many times that method is called). This means that every time
> another
> instance of that class is created there will be a new database query. I
> think we
> need to store the WikiPage object in RequestContext to be able to share
> that
> object and thus avoiding those database queries.
>

That sounds like it would be reasonable; any objections?

-- brion
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to