"Jack Phoenix" posted a comment on MediaWiki.r108076. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108076#c29019
Commit summary for MediaWiki.r108076: VoteNY: actually make this work under 1.18+, not just in ResourceLoader's debug mode. Changelist: *removed backwards-compatibility code *used HTML5 data attributes to store various information that we access in the JS file *incremented the extension's version number *removed ancient vote key stuff (the "vote key" was being passed to the AJAX function but it wasn't used in any of the functions) *updated Linker class, that class is now static *killd $wgTitle Some things are now a bit slower, i.e. if you click on the green voting box, then click again when the unvote link appears, it doesn't seem to change back to "vote" again...but at least it should work now. Jack Phoenix's comment: It depends; while it certainly looks funky in this context, it's true that I made fixes to SpecialTopRatings.php back in December 2011, as those fixes were very easy. Most of the code committed in this revision was written yesterday, though (because only yesterday I remembered about HTML5 and its useful data attributes). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
