"Krinkle" changed the status of MediaWiki.r94951 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#c29261
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r94951: new method to parse chunk delimiters Their format is a one liner: @@ -l,s +l,s @@ See http://en.wikipedia.org/wiki/Diff#Unified_format Krinkle's comment: (outdent) Okay, took a while but I've updated the wiki at the Windows server, seems like it's still throwing exceptions on some revisions. <br /> <b>Warning</b>: array_map() [<a href='function.array-map'>function.array-map</a>]: An error occurred while invoking the map callback in <b>C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\backend\DiffHighlighter.php</b> on line <b>87</b><br /> CodeDiffHighlighter::parseChunkDelimiter given an invalid chunk header: '@@ -1,15 +1 @@' Backtrace: <pre> #0 C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\backend\DiffHighlighter.php(220): CodeDiffHighlighter::parseChunkDelimiter('@@ -1,15 +1 @@?') #1 C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\backend\DiffHighlighter.php(116): CodeDiffHighlighter->handleChunkDelimiter('@@ -1,15 +1 @@?') #2 [internal function]: CodeDiffHighlighter->parseLine('@@ -1,15 +1 @@?') #3 C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\backend\DiffHighlighter.php(87): array_map(Array, Array) #4 C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\backend\DiffHighlighter.php(52): CodeDiffHighlighter->splitLines('Index: active/_...') #5 C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\ui\CodeRevisionView.php(474): CodeDiffHighlighter->render('Index: active/_...', Object(CodeRepository), Object(CodeRevision)) #6 C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\ui\CodeRevisionView.php(164): CodeRevisionView->formatDiff() #7 C:\xampp\htdocs\mediawiki-trunk\extensions-trunk\CodeReview\ui\SpecialCode.php(27): CodeRevisionView->execute() #8 C:\xampp\htdocs\mediawiki-trunk\includes\SpecialPageFactory.php(475): SpecialCode->execute('AcceptIt/6148') #9 C:\xampp\htdocs\mediawiki-trunk\includes\Wiki.php(251): SpecialPageFactory::executePath(Object(Title), Object(RequestContext)) #10 C:\xampp\htdocs\mediawiki-trunk\includes\Wiki.php(619): MediaWiki->performRequest() #11 C:\xampp\htdocs\mediawiki-trunk\includes\Wiki.php(539): MediaWiki->main() #12 C:\xampp\htdocs\mediawiki-trunk\index.php(58): MediaWiki->run() </pre> _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
