"Nikerabbit" changed the status of MediaWiki.r97055 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97055
Old status: new > New status: ok Commit summary for MediaWiki.r97055: RL2: Per CR on r96863, moved getCategoryTitle() to LocalGadgetRepo. Also turned it from a static method into an object method. Even though it could be static right now (it doesn't use $this), it seems more future-proof to do it this way. All current callers have a $repo object at hand, so making it non-static now doesn't break anything, and it's easier to make a non-static method static (from the callers' perspective) than to make a static method non-static. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview