"Catrope" changed the status of MediaWiki.r110209 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110209#c30415
Old Status: new > New Status: fixme Commit summary for MediaWiki.r110209: [Special:MovePage] Split new title input, fix bug 29454 (byteLimit), namespaceSelector * Two reasons: -- Limit bug: Limit can't be enforced if the two are together because only page_title is limited, the namespace prefix is not part of the title. Plus even then, there is still ambiguity with the various ways to denote namespaces (aliases) and whitespace freedom between namespace, colon and title. -- Extra feature: Now that the two are separate it' s easier for users to move across namespaces as one doesn't have to type, can't make spelling mistakes. Also, in the future we could exclude certain target namespaces that are not possible or not allowed (now one can perfectly submit a request to move from NS_CATEGORY or NS_FILE, only to get a warning on submission). By showing them disabled in the drop down this becomes clearer). * Keeps backwards compatibility for gadgets and permalinks generated by templates on wikis so that they can still pre-set the "new title" from a url the old way. The new way can also be pre-set from the url, and allows them to be set separately (wpNewTitleNs=10&wpNewTitleMain=Infobox) * Gadgets and templates linking to Special:MovePage with a preset target -- Old way (still works): wpNewTitle=Template:Infobox -- New way: wpNewTitleNs=10 (and/or) wpNewTitleMain=Infobox * Fixes bug 29454; Depends on r109990; -- (bug 29454) Enforce byteLimit for page title input on Special:MovePage Catrope's comment: <pre> + Xml::input( 'wpNewTitleMain', 60, $wgContLang->recodeForEdit( $newTitle->getBaseText() ), array( </pre> Is this use of getBaseText() deliberate? This means that if you supply ns=1 and title=User:Catrope/Foo , the form will be filled out with ns=Talk and title=User:Catrope , stripping the subpage component. If you want the full title text sans namespace, use <code>$newTitle->getText()</code> . Marking fixme because this feels wrong and isn't explained anywhere. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
