"Siebrand" posted a comment on MediaWiki.r111556. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111556#c31023
Commit summary for MediaWiki.r111556: Committing my work in embedded translation editor. * Only exposed when &translate-beta=1 is provided in the URL, or when double clicking messages * Please test functionally, feedback on the UI also welcome * The dialog editor should not be affected, other than translation suggestions are now loaded synchronously Siebrand's comment: Review comments: * Last message on page does not closing when clicking X. * The X in the header is ugly in some browsers. Needs to display in a consistent way. * Diff display is awkward with the borders. Should look similar to how the pop-up editor displays the diff. Tested in https://translatewiki.net/w/i.php?title=Special%3ATranslate&taction=translate&group=page-Translating%3AHow+to+start&language=nl&limit=100&task=view with key "How to start/howtostart/nl". _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview