"Preilly" posted a comment on MediaWiki.r112056.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112056#c31343

Commit summary for MediaWiki.r112056:

Added forward-compatibility with potential new wfIsConfiguredProxy function 
(introduced r111788) - this checks an IP against the list of configured squid 
proxies. This is preferred over wfIsTrustedProxy since wfIsTrustedProxy also 
runs a hook that gets used by an extension on the WMF cluster to check the IP 
against trusted open proxies as well as the configured squid proxies, which is 
not our desired behavior.

Preilly's comment:

You are missing a space around "))" after 'wfIsConfiguredProxy'.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to