"Robmoen" changed the status of MediaWiki.r112529 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112529#c31595
Old Status: new New Status: ok Commit summary for MediaWiki.r112529: use jquery where available instead of native javascript library Robmoen's comment: Marking ok. Though, Per JS conventions use typeof as an operator instead of a function. <pre> utilities = typeof(jQuery) !== "undefined" ? jQuery : function( el ) { if( typeof(el) === 'string' ) { </pre> Use: <pre> utilities = typeof jQuery !== 'undefined' ? jQuery : function( el ) { if( typeof el === 'string' ) { </pre> _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview