"Jpostlethwaite" changed the status of Wikimedia.r1383 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1383#c31610

Old Status: new
New Status: ok

Commit summary for Wikimedia.r1383:

followup r1338, r1377
For clarity, safety, and a bunch of other reasons: Killed the recursion and 
established the beginnings of a simplified date increment function.
Currently, it only handles 'month'. As such, it returns the target date (or 
closest possible if that day does not exist) in the month considered 'next' 
from the date passed in. The calling function will loop on it to get to its 
intended interval. The function that used to be recursive 
(_civicrm_recurring_globalcollect_get_next_sched_contribution_date_for_month) 
will continue to behave the same way it was always supposed to.

Jpostlethwaite's comment:

This seems to be working.

I will run some more tests.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to