"QChris" posted a comment on MediaWiki.r66638.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66638#c31773

Commit summary for MediaWiki.r66638:

* Remove compatibility code for pre-5.1 versions of PHP
* Re-connect to db after error in strencode()

QChris's comment:

The log message says to remove "pre-5.1 versions of PHP", but kills a guard for 
5.0.13 of /MySQL/.

Current INSTALL file lists >= MySQL-4.0.14 as requirement. So for users of 
MySQL between 4.0.14 and 5.0.(1)3, this yields an additional connection attempt.
But I assume the code is not executed often enough and the user base for those 
versions is too small to be relevant ;)

(If there are relevant users for those versions, the MySQL ChangeLog reports 
the change in default reconnection settings in version 5.0.3, not 5.0.13; just 
in case some problems arise between those versions)

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to