"Ryan lane" changed the status of MediaWiki.r113405 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113405#c31995

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r113405:

I'm fed up of new labs users having problems on initial login
because their key was in the wrong format.

When the key doesn't look to be in the right format:
a) Try to automatically convert it in the server. Much easier
than explaining where to find the option in the menu.
b) Reject it in other case, so at least they know upfront that,
and don't have to discover it the hard way when trying to login
after discarding the other possible reasons.

Ryan lane's comment:

This is a great change, but let's switch this to use openssh's ssh-keygen.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to