"Catrope" changed the status of MediaWiki.r113916 to "resolved" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113916#c32389
Old Status: fixme
New Status: resolved
Commit summary for MediaWiki.r113916:
AFTv5: sync commit, readded i18n msgs etc.
Catrope's comment:
<pre>
+ 'articlefeedbackv5-link-close-text1' => 'To remove this widget, go to',
+ 'articlefeedbackv5-link-close-linktext' => '"My Preferences > Appearances"',
+ 'articlefeedbackv5-link-close-linkurl' => '#',
+ 'articlefeedbackv5-link-close-text2' => 'then check this box:',
+ 'articlefeedbackv5-link-cllse-text3' => '"Don\'t show the Article Feedback
widget."',
</pre>
Per Siebrand in r113979, this is a lego message which should be cleaned up.
Create one message with 'To remove this widget, go to $1, then check this box.'
, and then build the link from the other message and insert it as $1.
<s>Marking fixme for this</s> oh it's been removed already, marking resolved.
<pre>
+tipsy {
</pre>
This was removed later, but for the record, it doesn't work, you probably
missed a dot here.
<pre>
+.tipsy-inner {
</pre>
This was removed later, but for the record: this and other rules concerning
tipsy should be namespaced so they only affect tipsy tooltips created by
ArticleFeedbackv5, not any other tooltips that might exist on the page.
<pre>
+ <a href="' + mw.msg( 'articlefeedbackv5-link-close-linkurl' ) + '">' +
mw.msg( 'articlefeedbackv5-link-close-linktext' ) + '</a>\
</pre>
This code was removed later, but for the record, this is not a secure way of
building HTML.
_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
