"Rsterbin" changed the status of MediaWiki.r114064 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114064#c32402
Old Status: fixme New Status: new Commit summary for MediaWiki.r114064: Brought trigger links into the plugin itself; styled flyover panel: - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js: * Brought in trigger links, standardized them, and added the disable flyover. - New property selectedLinks - New template disableFlyover - Added object triggerLinks (like buckets and ctas) - Added selecting and insertion of trigger links to init() - New methods selectTriggerLinks(), addTriggerLinks(), buildDisableFlyover(), and clickTriggerLink() - Updated buildLink() to handle a flexible number of replacements, and to handle tags other than links - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css: - Updated flyover styles to match latest mockup and to work with both link E and link A - Added trigger link styles from ext.articleFeedbackv5.css - modules/ext.articleFeedbackv5/ext.articleFeedbackv5.css: - Removed trigger link styles - modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js: - Removed building of trigger links - Plugin is now attached after it's been added to the page, so that trigger links can be inserted relative to it - ArticleFeedbackv5.i18n.php: - Changed messages and wording to match latest mockup - Put in real doc lines - ArticleFeedbackv5.hooks.php: - Updated to match new messages Rsterbin's comment: Fixed in followups; marking back to new. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview