Some notes on the UI interface: (i) it doesn't allow to review the commit message
(ii) the github-like comment and diff UI is nice, but the diffs aren't as informative: they don't seem to highlight extra whitespace and tabs as well as Gerrit. (iii) the interface showing the files is less informative: no list of files already checked, all changes in one page (wonderful for the commits editing 10+ files). (iv) it doesn't seem to support successive patch sets for one change, so maybe it's more post-commit centered than workflow-agnostic. So what should we do? Create another commit to fix the commit? Where will be the comments? On several pages? How will there be linked? (v) The work to adapt the software from pre-commit to post-commit. I don't understand how to fix a review. (vi) I don't understand how to test a change (yes it's a post-commit workflow, so just git pull, but in the case we transform Barkeep to a pre-commit...). Globally, I don't share the general enthusiasm and feeling about the UI ; I really think the Gerrit interface is more functional and more ergonomic, where Barkeep only gives a "2.0 fresh look". If it's only an interface issue, I would strongly advice to follow the rule "When it's not broken, don't fix it" and keep Gerrit instead to waste time and resources to hack Barkeep to have it suiting our pre-commit workflow need. On Mon, Jul 2, 2012 at 12:06 AM, Ryan Lane <rlan...@gmail.com> wrote: >> Yeah, that's right. What I meant to say (and thought I had said in >> some form later in that message) was that the puppet repo has >> post-commit review for most changes by ops staff, and pre-commit >> review for everything else (non-ops staff, volunteers, and certain >> changes by ops staff in some cases). >> > > And we'd gladly take better tools for doing post-commit review. Gerrit > handles this very poorly. Just having free-form tags in Gerrit would > likely fix this for our use case, though. > > Saved searches would be amazing. > > - Ryan > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Sébastien Santoro aka Dereckson http://www.dereckson.be/ _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
