Hi,

I would appreciate if somebody could have a look at
https://gerrit.wikimedia.org/r/139268

This is the second patch on a bug on CSSMin url() value remapping.
Remapping was thrown off if the CSS contained comments containing
curly braces. The fix just replaces all comments (except embed
directives) with placeholders and re-inserts them after the url()
value remapping.

The first patch (https://gerrit.wikimedia.org/r/#/c/138286/) had to be
reverted. It involved fixing the regex used for the url() remapping
directly and would have worked, too, only the rule became too
complicated, so preg_replace bailed out on large chunks of CSS.

So, anybody up to it?

Cheers,
Stephan

_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to