On 11/24/2014 11:47 PM, Legoktm wrote:
On 11/24/14 7:13 PM, Mark A. Hershberger wrote:
== Changes since 1.24.0-rc.2 ==
* The composer.json file has been renamed to composer.json.sample after
   Jamie Thingelstad reported that his composer.json was overwritten by
   the tarball.

Is there an associated bug report? We decided to revert a similar move
in core and this goes against the consensus in code review and the
wikitech discussions that were held months ago (back in May!), so I
strongly recommend reverting this.

First off, this "change"[1] was done outside of git meaning there was no
opportunity for code review and no possibility of a revert.

This brings up a question.  Where is the code that builds the tarball?

Matt Flaschen


_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to