Alexandre Julliard wrote:
>
> ChangeSet ID: 973399999982484669424593
> CVSROOT: /opt/cvs-commit
> Module name: wine
> Changes by: julliard@wine2. 00/11/04 23:53:19
>
> Modified files:
[snip]
>
> Log message:
> Declare debug channels in all dlls that need them; added imports of
> ntdll where necessary.
>
> Patch:
>http://cvs.winehq.com/patch.py?root=/opt/cvs-commit&logs=/opt/cvs-commit/CVSROOT/winecommitlog&id=973399999982484669424593
Alexandre,
looking at the patch, I think we should refine one of the variables in the Makefile:
SUBDIRS is used with two meanings :
1/ it's the list of the subdirs, from the current directory, in which the make process
shall recurse into
2/ it's the list of the subdirs, where the module located in the current directory
takes
some of its files
use of 1/ can be found in depend, clean targets for example
however, for case 2/, there are two different aspects
+ some DLLs (like DDraw) use subdirs to underline the architecture of the code, but
keep everything as a single module
+ some other DLLs (like winmm) use subdirs to store modules (DLLs) they can use
however, we use the same SUBDIRS macros for the last both
as a result, the recent debug channel modification lets have in winmm the debug
channels for all the modules winmm/mmsystem may use
of course it's not a big deal (a few bytes added to the file), but I still
think it's worth cleaning up the SUBDIRS stuff
may be we should have two different macros :
- SUBDIRS (only for recursion issues)
- SUBMODULE (as needed in WINMM/MMSYSTEM) case
do you think this is useful ?
A+
--
---------------
Eric Pouech (http://perso.wanadoo.fr/eric.pouech/)
"The future will be better tomorrow", Vice President Dan Quayle
