On Fri, 20 Jun 2003 21:01:57 -0500, you wrote:
> Modified files: > dlls/shell32 : shell32_main.c > > Log message: > Jason Edmeades <[EMAIL PROTECTED]> > SHGetFileInfo should tolerate null pointers. > > Patch: http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8543 This breaks the file dialog in Agent news reader: the directory tree is blank. Precisely the cause is this part: | @@ -297,6 +299,9 @@ | return 0; | } | | + /* psfi is NULL normally to query EXE type, if not none of the below makes | + sense anyway. Windows allows this and just returns FALSE */ | + if (psfi != NULL) return FALSE; this is obviously wrong (psfi is dereferenced in the remainder of the function). I just wonder if it should be removed, or is here a typo and should != be == ? Rein. -- Rein Klazes [EMAIL PROTECTED]
