Am Samstag, 29. November 2003 04:12 schrieb Dmitry Timoshkov:
> "Stefan Leichter" <[EMAIL PROTECTED]> wrote:
> > ChangeLog
> > --------------
> > added version info resource to regsvr32
>
> It's too late since Alxandre has committed the patch, but
> it's worth to mention that it's better to use a common
> pattern for creating version resources for Wine DLLSs,
> which uses wine/wine_common_ver.rc.
>
> Could you send a new patch for that?
looks like i have used one of the four place as example where it is done in a
different way
ChangeLog
--------------
changed the version resource to be create in the common way
--- ../wine/include/wine/wine_common_ver.rc 2003-09-11 00:14:27.000000000 +0200
+++ include/wine/wine_common_ver.rc 2003-11-29 10:31:17.000000000 +0100
@@ -42,6 +42,10 @@
#define WINE_FILENAME_STR ""
#endif
+#ifndef WINE_FILETYPE
+#define WINE_FILETYPE VFT_DLL
+#endif
+
#ifndef WINE_PRODUCTVERSION
#define WINE_PRODUCTVERSION 1,0,0,0
#endif
@@ -60,7 +64,7 @@
FILEFLAGSMASK 0
FILEFLAGS 0
FILEOS VOS_UNKNOWN
-FILETYPE VFT_DLL
+FILETYPE WINE_FILETYPE
FILESUBTYPE VFT2_UNKNOWN
{
BLOCK "StringFileInfo"
--- ../wine/programs/regsvr32/regsvr32.rc 2003-11-29 00:11:30.000000000 +0100
+++ programs/regsvr32/regsvr32.rc 2003-11-29 10:27:03.000000000 +0100
@@ -15,39 +15,15 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
- * FIXME: not sure about values of FILEFLAGSMASK, FILEOS, Translation
*/
-#include "windef.h"
-#include "winbase.h"
-#include "winver.h"
+#define WINE_FILEDESCRIPTION_STR "Wine Register Server"
+#define WINE_FILENAME_STR "REGSVR32"
+#define WINE_FILETYPE VFT_APP
+#define WINE_FILEVERSION 5,0,1586,1
+#define WINE_FILEVERSION_STR "5.0.1586.1"
-LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
+#define WINE_PRODUCTVERSION 5,0,1586,1
+#define WINE_PRODUCTVERSION_STR "5.0"
-1 VERSIONINFO
-FILEVERSION 5, 0, 1586, 1
-PRODUCTVERSION 5, 0, 1586, 1
-FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
-FILEOS VOS_DOS_WINDOWS32
-FILETYPE VFT_APP
-{
- BLOCK "StringFileInfo"
- {
- BLOCK "040904B0"
- {
- VALUE "CompanyName", "Wine Developer Team"
- VALUE "FileDescription", "Wine Register Server"
- VALUE "FileVersion", "0.01"
- VALUE "InternalName", "REGSVR32"
- VALUE "LegalCopyright", "Copyright (c) 2003 the Wine project authors"
- VALUE "OriginalFilename", "REGSVR32.EXE"
- VALUE "ProductName", "Wine"
- VALUE "ProductVersion", "1.00"
- }
- }
- BLOCK "VarFileInfo"
- {
- VALUE "Translation", 1030, 1200
- }
-}
+#include "wine/wine_common_ver.rc"
