Hi Mike, patching is clean on 20041019, however ..
fails with
make[2]: Entering directory `/tmp/wine-20041019/dlls/shell32'
../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./shell32.spec shell.spec.o shell.o authors.o autocomplete.o brsfolder.o changenotify.o classes.o clipboard.o control.o cpanelfolder.o dataobject.o debughlp.o dialogs.o dragdrophelper.o enumidlist.o folders.o iconcache.o memorystream.o pidl.o regsvr.o shell32_main.o shelllink.o shellole.o shellord.o shellpath.o shellreg.o shellstring.o shfldr_desktop.o shfldr_fs.o shfldr_mycomp.o shlexec.o shlfileop.o shlfolder.o shlfsbind.o shlmenu.o shlview.o shpolicy.o shv_bg_cmenu.o shv_item_cmenu.o systray.o shell32.dll.dbg.o shres.res version.res -o shell32.dll.so -L../../dlls -Wb,-dole32 -lshlwapi -lcomctl32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -L../../libs/wine -lwine -luuid -L../../libs/unicode -lwine_unicode -L../../libs/port -lwine_port
shell32_main.o(.text+0x23c6): In function `DllMain':
/usr/src/redhat/BUILD/wine-20041019/dlls/shell32/shell32_main.c:962: undefined reference to `SYSTRAY_Init'
collect2: ld returned 1 exit status
winegcc: gcc failed.
make[2]: *** [shell32.dll.so] Error 2
make[2]: Leaving directory `/tmp/wine-20041019/dlls/shell32'
make[1]: *** [shell32] Error 2
make[1]: Leaving directory `/tmp/wine-20041019/dlls'
make: *** [dlls] Error 2
Mike Hearn wrote:
Here it is, at last, just what the doctor ordered. All in a separate wineshell process, and with cleaner code to boot. No thread safety needed. Hopefully this is now satisfactory and can go in.
The intention is that wineshell becomes a generic explorer-alike process in terms of responsibility. For now, I have it being started automatically by shell32 (to avoid the startup penalty), and shutting down a few seconds after the last icon is gone like the wineserver. If we start putting more stuff in there like a DDE server, we may have to rethink that strategy.
ChangeLog: - Add a new wineshell process, and put system tray handling in there - Rewrite the shell32 systray handling to be out of process - Support the freedesktop.org XEMBED protocol
