Mike McCormack wrote:
I'm sorry I don't know how these things are handled in wine. I basically made these patches so we don't depend on libunicode in reactos anymore as these things are supported by the native api. However, these functions should now basically either link to ntdll (or in the "worst" case to msvcrt). I can't even compile and link wine because I haven't managed to setup a build environment... it however works fine in reactos compiling with mingw. As I'm not familiar with libc and the other stuff wine depends on, I'd appreciate if someone who has better knowledge in this area to "fix" these patches.
Thomas Weidenmueller wrote:
- sz = strlenW(fmt) + 1; + sz = wcslen(fmt) + 1;
libc and wine may have differing interpretations of what wchar_t. Specifically, if -fshort-wchar is not used, wchar_t will be int, won't it?
You'd be better off using lstrlenW() than wcslen(), but that will be slow since it has an exception handler. Alexandre was talking about making an inline wine only version of lstrlenW() without the exception handler to solve that problem.
Mike
It'd however be great if these libraries can be built without libunicode because it's something obsolete for reactos (and libunicode has been bugging some of us devs).
Best Regards, Thomas
