Juan Lang wrote:
- TRACE_(dmfileraw)(": data (size = 0x%08lX): '%s'\n", *pcbRead,
debugstr_an(pv, *pcbRead));
+ TRACE_(dmfileraw)(": data (size = 0x%08lX): '%s'\n", cb,
debugstr_an(pv, *pcbRead));
Should that be:
TRACE_(dmfileraw)(": data (size = 0x%08lX): '%s'\n", cb, debugstr_an(pv,
cb));
instead?
--Juan
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
You are right. I failed to notice the second use of the suspicious
pointer. Here is a corrected patch.
Alex Villacís Lasso
--- wine-20050524/dlls/dmloader/loaderstream.c 2005-04-18 05:30:56.000000000 -0500
+++ wine-20050524-patch/dlls/dmloader/loaderstream.c 2005-06-11 14:13:02.000000000 -0500
@@ -390,9 +390,9 @@
memcpy (pv, pByte, cb);
This->llPos += cb; /* move pointer */
/* FIXME: error checking would be nice */
- *pcbRead = cb;
+ if (pcbRead) *pcbRead = cb;
- TRACE_(dmfileraw)(": data (size = 0x%08lX): '%s'\n", *pcbRead, debugstr_an(pv, *pcbRead));
+ TRACE_(dmfileraw)(": data (size = 0x%08lX): '%s'\n", cb, debugstr_an(pv, cb));
return S_OK;
}
