Raphael wrote:
but it's of no use with the patch you sent, so why clobber the patch
with this ?
no because i think its better to avoid assert in this case on dbghelp code :)
But if you prefer i can restore original code
IMO the correct fix would in field insertion to return one of three values:
- success (didn't exist before)
- did exist before
- couldn't add
(instead of the current success/failure mode)
so that every debug info parser can pick what it wants
my main objection here is that you're making modifications for something
you don't use (in the patch you sent). For readability and acceptance of
patches it's better to only include it if you make use of it.
A+
--
Eric Pouech
