Hi Dan,
Thanks again for the suggestions. I did indeed run the conformance tests
on Windows -- passes with no problem. The conformance tests confirm that
the return value is not the range. Good catch for the limiting of cpMax,
it simplified the return logic. I also fixed the whitespace violations I
found.
Brian
Dan Kegel wrote:
Nice touch including the link to the bug!
Did you run the new test on Windows?
+ if(range.cpMin < 0)
+ {
+ range.cpMin = end;
+ range.cpMax = end;
+ }
+ ...
+
+ return (range.cpMax < textlen+1 ? range.cpMax : textlen+1) ;
MSDN says the return value is the range, not just cpMax. Are they really wrong?
Also, I suspect you want to limit cpMax at the same time as you do cpMin,
not after the fact... otherwise aren't you passing an invalid cpMax to
ME_SetSelection() ?
Finally, there are trivial whitespace style violations, I think
(missing space between if and the open paren).
- Dan
--
Wine for Windows ISVs: http://kegel.com/wine/isv
