On Fri, 12 May 2006, Huw Davies wrote:
[...]
There is a HAVE_SYS_TYPES_H though.  However since HAVE_SYS_TYPES
isn't defined, couldn't you remove the #include too?

Good point. I've removed it and will post an updated patch.

However while investigating this I discovered this comment in winapi_check:

   # This checks for a bunch of standard headers
   # There's stdlib.h, string.h and sys/types.h too but we don't
   # want to force ifdefs for those at this point.

Why don't we want to force ifdefs for these headers?

Either they are conditional and then having ifdefs in only 1/10 of the time is useless.

Or they are not and then there's no point in having HAVE_SYS_TYPES_H & co.

Any objection to patches that would switch to strict ifdef enforcement for these headers?

--
Francois Gouget <[EMAIL PROTECTED]>              http://fgouget.free.fr/
           Demander si un ordinateur peut penser revient à demander
                          si un sous-marin peut nager.


Reply via email to