Here's a patch I'm trying to make to implement the WM_GETICON message, which 
programs like GeoShell (a Win32 taskbar replacement) would use to get a 
taskbar icon for the running processes. I'm not quite sure if it's proper or 
not, though. Originally GeoShell would show no icon on the taskbar and print 
a lot of fixme messages about it being unsupported. With this patch it now 
(always) shows the Wine glass icon for programs, with no such fixme messages. 
Since I'm unable to try it on a real Windows machine, I don't know if it's 
the right behavior for it to always show the generic icon like that.

Feedback and help would be appreciated.
Index: dlls/user/message.c
===================================================================
RCS file: /home/wine/wine/dlls/user/message.c,v
retrieving revision 1.111
diff -u -r1.111 message.c
--- dlls/user/message.c	23 May 2006 12:48:46 -0000	1.111
+++ dlls/user/message.c	10 Jun 2006 23:19:01 -0000
@@ -625,6 +625,10 @@
         FIXME( "WM_NCPAINT hdc packing not supported yet\n" );
         data->count = -1;
         return 0;
+    case WM_GETICON:
+        /* WM_GETICON doesn't give or return any data. The result of the reply
+           is the value we care about */
+        return 0;
     case WM_PAINT:
         if (!wparam) return 0;
         /* fall through */
@@ -648,7 +652,6 @@
     case WM_PAINTCLIPBOARD:
     case WM_SIZECLIPBOARD:
     /* these contain HICON */
-    case WM_GETICON:
     case WM_SETICON:
     case WM_QUERYDRAGICON:
     case WM_QUERYPARKICON:
@@ -911,7 +914,6 @@
     case WM_PAINTCLIPBOARD:
     case WM_SIZECLIPBOARD:
     /* these contain HICON */
-    case WM_GETICON:
     case WM_SETICON:
     case WM_QUERYDRAGICON:
     case WM_QUERYPARKICON:


Reply via email to