Re: Fix potential NULL deref in IWineD3DSurfaceImpl_LockRect

[Chris]

On Monday 10 July 2006 09:43, you wrote:
> I can't find this patch anywhere via google and I don't have it in my mails
> here, so I can't comment on the patch directly, but from your description
> I'd say that the NULL deref was introduced by a patch of mine(the one which
> enabled single buffering). Can you mail me the patch?

Sure. Patch attached..

Index: dlls/wined3d/surface.c
===================================================================
RCS file: /home/wine/wine/dlls/wined3d/surface.c,v
retrieving revision 1.89
diff -u -r1.89 surface.c
--- dlls/wined3d/surface.c	6 Jul 2006 11:11:09 -0000	1.89
+++ dlls/wined3d/surface.c	7 Jul 2006 05:10:08 -0000
@@ -539,7 +539,7 @@
 
             /* NOTE: In a shared context environment the renderTarget will use the same context as the implicit swapchain (we're not in a shared environment yet! */
             if ((swapchain == targetSwapChain && targetSwapChain != NULL) || iface == myDevice->renderTarget) {
-                    if (iface == swapchain->frontBuffer) {
+                    if (swapchain && iface == swapchain->frontBuffer) {
                         TRACE("locking front\n");
                         glReadBuffer(GL_FRONT);
                     }