Hello!
Benjamin Arai wrote:
A bug was submitted (http://bugs.winehq.org/show_bug.cgi?id=5306) that
To be honest i do not think that bug is really valid:
a.) he hasn't enough swap configured or
b.) gcc problem
vartest.c was getting too large and that it needs to be smaller. I
It is big but that is more a compile time than runtime issue. It runs
very fast but it's dog slow when compiling. But so is also vartype.c.
don't think to much can be done about the size but I did notice that all
There are some very heavy macros at least in the variant arithmetic
function tests. I was pondering to make them functions instead so those
will be compiled and optimized only once. But as it isn't a runtime
problem i went myself for the easy path of just keeping the macros.
the tests for varformat.c are being put into vartest.c as opposed to
making a new test file test/varformat.c. Would there be any problems if
I create a new test file for varformat.c and move the appropriate test
from vartest.c to it?
You can do that; i do not think that many people mind about that. The
only reason for that would be to make the vartest.c file more readable.
But if you end up having to replace a lot of the infrastructure at the
beginning of the file (macros, defines and that like) than it's not
worth the effort.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engineer Fax.: +49-711-96437-111
Red Hat GmbH Email: [EMAIL PROTECTED]
Hauptstaetterstr. 58 http://www.redhat.de/
D-70178 Stuttgart
