On Sat, 2006-11-25 at 07:33 -0800, James Hawkins wrote: > The if 0 exclusion is enough because it shows that at one point > advpack checked for the null parameter, but now it doesn't on some > versions. We check for the null param, so we're on the safe side of > the fence. Not many apps/installers depend on a certain function > crashing with a null param, though there are one or two we've seen. > advpack is almost completely undocumented and is only used by the IE > and mdac installers (basically), so this issue is inconsequential. > Also, Alexandre has specifically said that he doesn't want the tests > filled with version checks. > The one mentioned is maybe the wrong example as it's quite clear. The point however is that this test will never be run anymore as long as nobody cares.
Cheers, Paul.
