Vitaliy Margolen wrote:
Change Log:
- server: Reverse return value and status in token_access_check to be
consistent.
- server: Do not set successful status by default. Set it explicitly in each
case.
- advapi32: Add few tests.
It is some-what confusing to have token_access_check return 2 statuses. And
even more so, when it doesn't match with the native. Usually function returns
a status if call to it succeeded (all parameters are valid, caller allowed
to perform requested operation, etc). And extra parameters would indicate
if some check(s) succeeded or not.
I agree with the spirit of this patch, but it is not clear which part of
this patch fixes the new tests. So please split this patch up into
tests, cleanups and bug fixes.
@@ -866,24 +862,17 @@ static unsigned int token_access_check(
ace = ace_next( ace );
}
+ done:
The indentation of this label is incorrect.
--
Rob Shearman
