Tom Spear schrieb: > On 4/24/07, James Hawkins <[EMAIL PROTECTED]> wrote: >> On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: >> > This patch makes the wine uninstaller check HKCU for uninstall entries >> > in addition to HKLM. >> > >> >> +const int numrootkeys = 2; >> +static const DWORD maxSubkeyNameLen = 255; >> >> const variables should be all uppercase to differentiate them from >> non-const variables. Imo it's more common to use all uppercase names only for macros. And i think it is mostly done that way in wine. In fact you have to look quite hard to find an all uppercase variable name ;)
But are there any reasons why making that a variable at all? #define MAX_SUBKEY_LEN 255 > Undid the random whitespace change. Any others? it is still there in try4 - + RemoveSpecificProgram( argv[i++] ); there is one more - if(count != 0) + if (count != 0) >> + WINE_TRACE("allocated entry #%d: %s (%s), %s\n", >> + numentries, wine_dbgstr_w(entries[numentries-1].key), >> wine_dbgstr_w(entries[numentries-1].descr), >> wine_dbgstr_w(entries[numentries-1].command)); >> >> You mixed tabs and spaces, and that line is too long. > > Who originally wrote this damn code and how did it get by you in the > first place? If it's too long, please give more info on how I can > make it shorter, while still getting the same output. Especially > since I didnt write that line. As a suggestion: uninst_entry *entry; ... entry = &entries[numentries - 1]; Now you only need to write entry->xxx instead of entries[numentries - 1].xxx in that whole block and get slightly shorter lines.