On Wed, 24 Oct 2007, Robert Shearman wrote: > It's a false positive, probably coming from the compiler not picking > up that it is set when the exception variable is false and that when > exception is true it is set earlier in the function.
Ah, thanks for the analysis. I couldn't convince myself that was the case. ;-) > If you're going to change the code at all, then at least keep to the > coding convention used in the rest of the function and use NULL here. Fair point! Updated patch below. Gerald Index: dlls/rpcrt4/rpc_server.c =================================================================== RCS file: /home/wine/wine/dlls/rpcrt4/rpc_server.c,v retrieving revision 1.85 diff -u -3 -p -r1.85 rpc_server.c --- dlls/rpcrt4/rpc_server.c 22 Aug 2007 11:24:40 -0000 1.85 +++ dlls/rpcrt4/rpc_server.c 24 Oct 2007 12:32:18 -0000 @@ -167,7 +167,7 @@ static void RPCRT4_process_packet(RpcCon RpcServerInterface* sif; RPC_DISPATCH_FUNCTION func; UUID *object_uuid; - RpcPktHdr *response; + RpcPktHdr *response = NULL; void *buf = msg->Buffer; RPC_STATUS status; BOOL exception;