Dan Kegel wrote: > On Wed, Mar 26, 2008 at 4:04 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: >> > This would require reviewing all uses of WideCharToMultiByte in Wine, >> > many places get this wrong. Unless you have an app that requires this >> > fix I'd suggest to leave the test as todo_wine for now. >> >> Would that be a good janitorial work to be done before Wine 1.0? I feel >> like I'm getting tired of translating ... > > Sure. A quick grep finds some obvious ones: > > $ find . -name '*.c' | xargs grep WideCharToMultiByte | grep ' -1, NULL, > NULL)'
> The first step, as Alexandre says, is to add the test with a todo_wine > around the negative destlen test. > I would have done it but I'm more than happy to let you run with it. Please go ahead and resubmit the patch with todo_wine around it. I don't want to claim ownership for the patch you wrote. bye michael