2008/4/26 James Hawkins <[EMAIL PROTECTED]>:
> Hi,
>
>  The tests aren't run anyway in this case.
>
>  Changelog:
>  * Remove a test that fails in VMs.
...
>              hr = IDirect3D7_CreateDevice(Direct3D, &IID_IDirect3DRefDevice, 
> Surface, &Direct3DDevice);
>          }
>      }
> -    ok(hr == D3D_OK, "IDirect3D7_CreateDevice failed with %08x\n", hr);

Wouldn't it be better to move the ok line to directly after the
IDirect3D7_CreateDevice call? That way, on VM machines the test will
not get run and on non-VM machines it will, as it is a valid test in
that case.

- Reece


Reply via email to