On Sat, Apr 26, 2008 at 1:54 PM, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > Austin English wrote: > > On 4/26/08, *Lei Zhang* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > > > wrote: > > > > On Sat, Apr 26, 2008 at 10:37 AM, Lei Zhang <[EMAIL PROTECTED] > > > <mailto:[EMAIL PROTECTED]>> wrote: > > > > > > On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard > > > <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote: > > > > Module: wine > > > > Branch: master > > > > Commit: faaccca59be08be547ec4e1948b6306eff3808a2 > > > > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e1948b6306eff3808a2 > > > > > > > > Author: Dan Kegel <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > > > > > > Date: Tue Apr 22 17:56:36 2008 -0700 > > > > > > > > winecfg: Restrict dpi slider to sane values. > > > > > > > > --- > > > > > > > > programs/winecfg/x11drvdlg.c | 4 ++-- > > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/programs/winecfg/x11drvdlg.c > > b/programs/winecfg/x11drvdlg.c > > > > index bfa6ec5..c0ec058 100644 > > > > --- a/programs/winecfg/x11drvdlg.c > > > > +++ b/programs/winecfg/x11drvdlg.c > > > > @@ -35,9 +35,9 @@ > > > > > > > > WINE_DEFAULT_DEBUG_CHANNEL(winecfg); > > > > > > > > -#define RES_MAXLEN 5 /* the maximum number of characters in > > a screen dimension. 5 digits should be plenty, what kind of crazy > > person runs their screen >10,000 pixels across? */ > > > > +#define RES_MAXLEN 5 /* max number of digits in a screen > > dimension. 5 digits should be plenty */ > > > > #define MINDPI 96 > > > > -#define MAXDPI 480 > > > > +#define MAXDPI 144 /* making this too high surprises and > > hurts users */ > > > > #define DEFDPI 96 > > > > > > > > #define IDT_DPIEDIT 0x1234 > > > > > > > > > > > > > > > > > > > > > > Dan, this basically reverted commit > > > 0110512904d9c646abef416819a057c06d3f2c97, which bumped MAXDPI > > from 160 > > > to 480 because some users specifically requested the ability for > > > higher DPI settings. > > > > > > I think we need to decide what we want and stop the tug-o-war. > > > > > > > > > Please see bug 9715. > > > > > > The change was specifically requested. A warning if someone sets it over > > 150, or a small explanation in winecfg would be better IMHO. > > > > > > ------------------------------------------------------------------------ > > > > > For anyone who wants more then 150 they can change that in the registry. > Honestly I've yet to see a single device with such a high DPI! > > And since by definition users will do everything to screw themselves up we > have to make it hard enough so majority will just give up. > > Vitaliy. > > >
How about something like the following, along with restoring back to 480 max? diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc index 65b6fd1..97550c0 100644 --- a/programs/winecfg/En.rc +++ b/programs/winecfg/En.rc @@ -87,7 +87,7 @@ BEGIN COMBOBOX IDC_D3D_VSHADER_MODE,100,201,145,70,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP CONTROL "Allow &Pixel Shader (if supported by hardware)",IDC_D3D_PSHADER_MODE,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,15,219,230,10 - GROUPBOX " Screen &Resolution ",IDC_STATIC,8,242,244,25 + GROUPBOX " Screen &Resolution - Don't change this if you don't know what it is! ",IDC_STATIC,8,242,244,25 CONTROL "", IDC_RES_TRACKBAR, "msctls_trackbar32",WS_TABSTOP,12,250,187,15 EDITTEXT IDC_RES_DPIEDIT,204,250,23,13,ES_NUMBER|WS_TABSTOP LTEXT "dpi",IDC_STATIC,235,252,10,8