On Mon, Jun 30, 2008 at 9:50 AM, Louis. Lenders <[EMAIL PROTECTED]> wrote: > Hi, any comments on this one? > btw, is there a reason i never ever receive any comments on my patches when > they are rejected? If so, please tell me, that'll save me a lot of time of > sending them in... > > ----- Forwarded Message ---- > From: Louis. Lenders <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Sent: Thursday, 26 June, 2008 3:20:04 AM > Subject: Re: programs: add rudimentary dxdiag > > Hi, some apps like Gameshadow (http://www.gameshadow.com/) check for > dxdiag.exe, and give an error if it's not found, so wine needs its own. > Instead of simple stub, this patch also adds the (simplified) d3d test > like seen in native dxdiag, so users can test if their d3d is setup > correctly. Screenshot can be seen here: > http://bugs.winehq.org/attachment.cgi?id=14342 > > A few remarks: > > -patch contains binary code for a bitmap, so to apply again i had to do > git apply dx.patch > git add programs/dxdiag/ > tools/make_makefiles > autoconf > > maybe there's a simpler way, but i dunno > > - code for spinning cube was partially based on spinning cube code > scattered all over the internet > -rest was ripped of winecfg > - There' s a problem while minizing the d3d-window, but running it in > wine-0.9.22 it all goes fine, so this must be a regression somewhere, and > not a bug in the attached code. I'll go after that later. > - Hopefully you're not to picky on this patch, it 's quite some line's of > code,and i'm sure things need to be improved, but this does not affect > wine's core code but os rather an enhancement, and it 's not really possible > to send it in in small chuncks. > > > > > ________________________________ > Not happy with your email address? > Get the one you really want - millions of new email addresses available now > at Yahoo! > ________________________________ > Not happy with your email address? > Get the one you really want - millions of new email addresses available now > at Yahoo! > > >
Like I said in the bug, you should add dxdiag to configure.ac/Makefile.in/etc. -Austin