On Wed, Sep 10, 2008 at 4:55 AM, Juan Lang <[EMAIL PROTECTED]> wrote: > Hi Jeff, > > + if(sock == INVALID_SOCKET) > + skip("Creating the socket failed: %d, skipping test.\n", > WSAGetLastError()); > skip needs a return too. > > + ret = ioctlsocket(sock, cmds[i], (u_long *)1); > + if(ok(ret == SOCKET_ERROR, "ioctlsocket succeeded unexpectedly\n")) > + { > I think you mean: > ok(ret == SOCKET_ERROR...) > if (ret == SOCKET_ERROR) > { > } > although really the if is unnecessary, as you won't cause a crash if > the first test fails. > --Juan >
Oops, yes, there should be a return there. if(ok(expr, seems perfectly valid, but yes I see that it could be considered unnecessary. I only added the if expression because printing the value of WSALastError(); didn't seem relevant if ioctlsocket succeeded. I'll remove the if to simplify it. Thanks for the feedback -Jeff