On Wed, Oct 22, 2008 at 10:41:00AM +0200, Hans Leidekker wrote: > On Tuesday 21 October 2008 19:06:20 Juan Lang wrote: > > > But you don't check whether those conditions are true, and you march > > ahead and install the certificate into the root store whether or not > > they are true. I'm sorry, but the code is just not correct. Please > > write some test cases. > > It's a stub of course, so it doesn't always do the right thing. We have > many of these in Wine, and that's OK as long as you are warned about the > shortcomings. > > If I'm right about typical usage of this function it will do the right > thing more often than not, which is pretty good for a stub.
It is however unsecure when I am reading that right ;) Ciao, Marcus