> From: Rob Shearman [mailto:robertshear...@gmail.com] > > - error = RegCreateKeyEx(HKEY_CLASSES_ROOT, buffer, 0, NULL, 0, > > KEY_SET_VALUE, NULL, &hkey, > > + error = RegCreateKeyEx(HKEY_CURRENT_USER, buffer, 0, NULL, 0, > > KEY_SET_VALUE, NULL, &hkey, > > This appears to have caused some regressions in running the > tests on older versions of Windows: > http://test.winehq.org/data/d0e77f8a47016c6f69e3a6b5a8bed8f620f1a8f1/nt4_cw-nt4sp6/ole32:marshal.html > versus before: > http://test.winehq.org/data/f63d950df75bdebbad3278790c6c9d11bfe1b226/nt4_cw-nt4sp6/ole32:marshal.html > > While I can see how using HKEY_CURRENT_USER instead of > HKEY_CLASSES_ROOT can help developers using a standard user > rather than Admin on Windows, I don't see it as useful in > general as a lot of the tests emulate what installers do and > hence depend on having full access to the system.
Agreed. I'll submit a patch to revert this part of my change. Ge.