Hi Warren, > Everything works well and i would like some feedback.
+ if (!strcmp(buf, "enabled")) + CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_CHECKED); + else + CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_UNCHECKED); + HeapFree(GetProcessHeap(), 0, buf); The HeapFree should be outdented. + char *memory; + if (updating_ui) return; + Minor nit: move the blank line between the variable declaration and the updating_ui check. + int selected_mode = selected_mode = SendDlgItemMessage(hDlg, IDC_D3D_RENDERING_MODE, CB_GETCURSEL, 0, 0); You can't declare variables other than at the beginning of a block in ANSI C. + unsigned int it = SendMessage(IDC_D3D_RENDERING_MODE, CB_GETTOPINDEX, 0, 0); Same here. + if (updating_ui) break; + SendMessage(GetParent(hDlg), PSM_CHANGED, 0, 0); + switch (LOWORD(wParam)) { + case IDOK: + d3d_advanced_settings_save(hDlg); + EndDialog(hDlg, wParam); + return TRUE; You've got some screwy indentation going on here. Please be consistent. Avoid tabs too, please. + case IDC_D3D_GLSL: on_d3d_glsl_clicked(hDlg); break; + case IDC_D3D_ADVANCED: on_d3d_advanced(hDlg); break; Same here. - case IDC_D3D_VSHADER_MODE: on_d3d_vshader_mode_changed(hDlg); break; + case IDC_D3D_VSHADER_MODE: on_d3d_vshader_mode_changed(hDlg); break; Please avoid whitespace-only changes in your patch. Regards, --Juan