Hi Dan,

Dan Kegel wrote:
Hi Jacek,
why do you have tls_list in
http://www.winehq.org/pipermail/wine-patches/2009-May/072833.html
?  The usual idiom is to just free each thread's data in THREAD_DETACH,
isn't it?

THREAD_DETACH is called only if thread detaches before urlmon.dll is unloaded. When urlmon.dll is unloaded only PROCESS_DETACH is called and we have to free TLS resources of all threads to avoid leaks (I don't consider such leaks as a serious problem, but it's better to avoid them).

I ran into this while chasing a crash regression in Sketchup, see
Anastasius' comments in http://bugs.winehq.org/show_bug.cgi?id=18601

I've attached a patch to the bug.


Thanks,
   Jacek



Reply via email to