Alexander Nicolaysen Sørnes wrote:
Hello,

Could someone give me a hint as to what is wrong with the following patches?

http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html
http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html

They only adds some defines plus a stub, so hopefully there isn't that much I can have done wrong :)



Alexander N. Sørnes
Hi, Alexander.

First of all constant defines should go to winnt.h to match PSDK.
Next I found RtlGetProductInfo() call in winnt.h. That's make me think that kernel32 call should be a thin wrapper over this ntdll call. I don't have Vista installed (I suppose it's Vista related call), so I can't check.

After that it might be nice to have a combo in winecfg to choose edition - as I know upcoming Win7 also has this product categories. Default value could be Ultimate of course. And combo should only appear on >= Vista.

Nikolay S.



Reply via email to