2009/8/6 Stefan Dösinger <ste...@codeweavers.com>:
> That's why I still think we should use behavior flags as a last resort, and
> use other problem specific ways where possible and reasonable. (an example
> for what's not reasonable: Clone the entire private data code in ddraw to
> avoid the AddRef - I clearly prefer a behavior flag for that)
>
Actually, if you wanted to avoid create flags, handling that AddRef in
ddraw would be less ugly than what patch 4 does. (And no, you don't
need to clone resource.c for that, just return the flags from
resource_get_private_data() and its callers, and immediately call
Release() in the appropriate case in ddraw.)


Reply via email to